Skip to content

Implement Dashboard with Token and NFT Vaults components.#26

Closed
MarcusDavidG wants to merge 12 commits intoSpherre-Labs:mainfrom
MarcusDavidG:feature/build-token-nft-vaults-ui
Closed

Implement Dashboard with Token and NFT Vaults components.#26
MarcusDavidG wants to merge 12 commits intoSpherre-Labs:mainfrom
MarcusDavidG:feature/build-token-nft-vaults-ui

Conversation

@MarcusDavidG
Copy link

@MarcusDavidG MarcusDavidG commented Mar 23, 2025

Description

This pull request introduces new components that integrates two key features: Token Vaults and NFT Vaults.

Changes Made:

  • TokenVaults Component: Displays token details in a styled table, including coin name, price, balance, value, and size.
  • NFTVaults Component: Showcases NFTs in a grid layout with individual cards, displaying the image, username, and price for each NFT.

Fixes #19

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation update
  • Other (please describe)

How Has This Been Tested?

  • Visual inspection of the application to ensure components render correctly.

  • Functionality checks to verify that data is displayed accurately in both TokenVaults and NFTVaults.

  • Responsive design testing on various screen sizes.

  • No console errors or warnings during operation.

  • Unit tests

  • Integration tests

  • Manual tests

  • Other (please describe)

Checklist:

  • I have read the contributing guidelines.
  • I have updated the documentation (if applicable).
  • My changes do not break existing functionality.
  • I have added tests that cover my changes (if applicable).
  • All new and existing tests pass.
  • I have included screenshots or GIFs to demonstrate the changes (if applicable).

…ults component displays token details in a styled table, while the NFTVaults component showcases NFTs in a grid layout with individual cards.
@0xDeon
Copy link
Contributor

0xDeon commented Mar 25, 2025

Can u please send a screenshoot of the page @MarcusDavidG

…nto feature/build-token-nft-vaults-ui

Merge updates from the main branch into feature/build-token-nft-vaults-ui
@MarcusDavidG
Copy link
Author

Screenshot from 2025-03-26 10-37-00
Screenshot from 2025-03-26 10-40-52

@0xDeon
Copy link
Contributor

0xDeon commented Mar 26, 2025

This looks nothing like the figma design

@MarcusDavidG
Copy link
Author

What's left are images for the nft's and a starknet logo...I checked but couldn't find them in any of the folders

@MarcusDavidG
Copy link
Author

I can insert them now if available or am I allowed to use placeholder images?

@0xDeon
Copy link
Contributor

0xDeon commented Mar 26, 2025

What's left are images for the nft's and a starknet logo...I checked but couldn't find them in any of the folders

You are suppose to export them from figma
I really shouldn't have to explain this to u

@MarcusDavidG
Copy link
Author

Updating images ASAP!

@0xDeon
Copy link
Contributor

0xDeon commented Mar 26, 2025

Updating images ASAP!

NFT.Spherre.mp4

Please pull from main
There is already a blueprint to what u are already building
Just dd the toke and NFT tables under this part of the table then wotk on the onclick logic

Please the table should match the figma
image

@0xDeon
Copy link
Contributor

0xDeon commented Mar 27, 2025

@MarcusDavidG Whats the update on this please?

@MarcusDavidG
Copy link
Author

MarcusDavidG commented Mar 27, 2025

done with inserting the images...changes have been committed, awaiting review.

Tokens
Screenshot from 2025-03-27 14-44-46

NFTVault
Screenshot from 2025-03-27 14-31-09

@0xDeon
Copy link
Contributor

0xDeon commented Mar 29, 2025

@MarcusDavidG Seems u arent getting the design indepthly
Can u at least mount your design to the dapp page please

@MarcusDavidG
Copy link
Author

Alright 👌

@MarcusDavidG
Copy link
Author

@MarcusDavidG Seems u arent getting the design indepthly Can u at least mount your design to the dapp page please

Done!

@codebestia
Copy link
Member

Hello @MarcusDavidG
Please format your code.

@MarcusDavidG
Copy link
Author

Hello @MarcusDavidG Please format your code.

Done chief, please review

@0xDeon
Copy link
Contributor

0xDeon commented Mar 29, 2025

Hello @MarcusDavidG Please format your code.

Done chief, please review

Just so u know this is howyour work is being displayed
I'm unassigning u now

image

@codebestia codebestia closed this Apr 12, 2025
@MarcusDavidG MarcusDavidG deleted the feature/build-token-nft-vaults-ui branch April 12, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUILD TOKEN AND NFT VAULTS UI WITH SMOOTH TRANSITION

3 participants